repair: refactor to remove callbacks #4886
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emwang-jump
force-pushed
the
emwang/repair-clean
branch
4 times, most recently
from
1a0b692 to
2a832c3
Compare
emwang-jump
force-pushed
the
emwang/repair-clean
branch
from
2a832c3 to
5c56d94
Compare
lidatong
reviewed
Apr 28, 2025
src/discof/repair/fd_repair_tile.c
Outdated
| FD_TEST(0 == fd_repair_protocol_encode(&protocol, &ctx)); | ||
| ulong buflen = (ulong)((uchar*)ctx.data - buf); | ||
|
|
||
| repair_send_intake_packet( buf, buflen, peer_addr, self_ip4_addr, repair_tile_ctx ); |
There was a problem hiding this comment.
what i actually was thinking is this would just fill the packet inside a caller provided buf arg
fd_repair_handle_ping( fd_repair_tile_ctx_t * repair_tile_ctx,
fd_repair_t * glob,
fd_gossip_ping_t const * ping,
fd_gossip_peer_addr_t const * peer_addr,
uint self_ip4_addr,
uchar * buf,
ulong * buf_sz ) {and then the caller would be responsible for calling repair_send_intake_packet (which can probably be deleted and just directly call send_packet)
as opposed to invoking the function itself
src/discof/repair/fd_repair_tile.c
Outdated
| if( shred == NULL ) { | ||
| FD_LOG_WARNING(("invalid shread")); | ||
| } else { | ||
| repair_shred_deliver(shred, shredlen, src_addr, &val->id, repair_tile_ctx); |
There was a problem hiding this comment.
similar to above, i think a cleaner API would be to not actually call repair_shred_deliver
(also we can probably clean this up. the mutation of active table should be managed by caller separately vs. inside this function. but this can happen in a later PR)
src/discof/repair/fd_repair_tile.c
Outdated
| fd_memcpy( buf + 4U, &sig, 64U ); | ||
|
|
||
| uint src_ip4_addr = 0U; /* unknown */ | ||
| repair_send_intake_packet( buf, buflen, addr, src_ip4_addr, repair_tile_ctx ); |
src/discof/repair/fd_repair_tile.c
Outdated
| FD_TEST(0 == fd_repair_response_encode(&gmsg, &ctx)); | ||
| ulong buflen = (ulong)((uchar*)ctx.data - buf); | ||
|
|
||
| repair_send_serve_packet( buf, buflen, dst_addr, src_ip4_addr, repair_tile_ctx ); |
src/discof/repair/fd_repair_tile.c
Outdated
| } | ||
| fd_hash_copy( &val->id, &header->sender ); | ||
| val->good = 0; | ||
| fd_repair_send_ping( repair_tile_ctx, glob, peer_addr, self_ip4_addr, val ); |
There was a problem hiding this comment.
same, but dont worry about changing this function since we don't need it right now
lidatong
approved these changes
Apr 28, 2025
emwang-jump
force-pushed
the
emwang/repair-clean
branch
from
c8eab47 to
0acb199
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pushed directly to repair-replay-link