topo, funk: change Funk workspace use unlocked pages #5470
Merged
+320
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topointon-jump
force-pushed
the
topointon/funk-unpinned-pages
branch
7 times, most recently
from
251804a to
ee73f49
Compare
topointon-jump
force-pushed
the
topointon/funk-unpinned-pages
branch
3 times, most recently
from
dc4a7b5 to
1ae013a
Compare
topointon-jump
changed the title
topointon-jump
force-pushed
the
topointon/funk-unpinned-pages
branch
from
1ae013a to
f32fb51
Compare
mmcgee-jump
reviewed
Jul 9, 2025
mmcgee-jump
reviewed
Jul 9, 2025
mmcgee-jump
reviewed
Jul 9, 2025
mmcgee-jump
reviewed
Jul 9, 2025
mmcgee-jump
reviewed
Jul 9, 2025
mmcgee-jump
reviewed
Jul 9, 2025
mmcgee-jump
reviewed
Jul 9, 2025
mmcgee-jump
reviewed
Jul 9, 2025
mmcgee-jump
reviewed
Jul 9, 2025
mmcgee-jump
reviewed
Jul 9, 2025
mmcgee-jump
reviewed
Jul 9, 2025
mmcgee-jump
reviewed
Jul 9, 2025
topointon-jump
force-pushed
the
topointon/funk-unpinned-pages
branch
3 times, most recently
from
1d18412 to
df87fce
Compare
ripatel-fd
reviewed
Jul 9, 2025
|
|
||
| /* Create the directory for the normal pages, where the files backing memory-mapped unlocked workspaces can be stored. */ | ||
| FD_LOG_NOTICE(( "RUN: `mkdir -p %s`", path )); | ||
| if( FD_UNLIKELY( -1==fd_file_util_mkdir_all( path, config->uid, config->gid ) ) ) { |
There was a problem hiding this comment.
I don't get this thing. What is a normalpage configure stage? The 4K page equivalent to hugetlbfs is tmpfs.
There was a problem hiding this comment.
If it's for normal on-disk data, wouldn't it make more sense to just have a ledger directory instead? We can temporarily use it for disk-backed funk and then change it later on to be the backing store for the actual DB
There was a problem hiding this comment.
The problem is it's integrated into the topology system, and expects a "workspace" which we have whole special code paths for, it's a little tricky to just get a workspace to mount in the ledger directory.
There was a problem hiding this comment.
Disgusting but fine with me, I suppose it will get reverted
topointon-jump
force-pushed
the
topointon/funk-unpinned-pages
branch
2 times, most recently
from
cfc00de to
3dccb73
Compare
topointon-jump
force-pushed
the
topointon/funk-unpinned-pages
branch
4 times, most recently
from
67c867b to
beb47f5
Compare
mmcgee-jump
force-pushed
the
topointon/funk-unpinned-pages
branch
from
beb47f5 to
fffc0c8
Compare
mmcgee-jump
previously approved these changes
Jul 10, 2025
topointon-jump
force-pushed
the
topointon/funk-unpinned-pages
branch
from
fffc0c8 to
3a726eb
Compare
topointon-jump
force-pushed
the
topointon/funk-unpinned-pages
branch
3 times, most recently
from
0dd2afe to
72d18f3
Compare
topointon-jump
force-pushed
the
topointon/funk-unpinned-pages
branch
from
72d18f3 to
dac1cae
Compare
mmcgee-jump
approved these changes
Jul 14, 2025
ibhatt-jumptrading
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the Funk workspace to use unlocked, unpinned pages that are not required to be resident in physical memory. This enables running large ledgers on machines with smaller memory.