runtime: add missing unlock in fd_banks_get_bank #5491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidatong
reviewed
Jul 10, 2025
| @@ -445,6 +445,7 @@ fd_banks_get_bank( fd_banks_t * banks, ulong slot ) { | |||
| bank = fd_banks_map_ele_query( bank_map, &slot, NULL, bank_pool ); | |||
| if( FD_UNLIKELY( !bank ) ) { | |||
| FD_LOG_WARNING(( "Failed to get bank" )); | |||
| fd_rwlock_unread( &banks->rwlock ); | |||
There was a problem hiding this comment.
wait shouldnt the caller be retaining the read lock here? how does the pointer stay valid on return -- its not a copy?
There was a problem hiding this comment.
github's PR UI is idiotic and doesn't let me tag other lines, but referring to line 452 not this
|
I spoke with charlie, the caller does indeed need locks when they use use a bank. You don't want a bank you are using to get published away |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.