Skip to content

runtime: add missing unlock in fd_banks_get_bank #5491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

runtime: add missing unlock in fd_banks_get_bank #5491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/flamenco/runtime/fd_bank.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,7 @@ fd_banks_get_bank( fd_banks_t * banks, ulong slot ) {
bank = fd_banks_map_ele_query( bank_map, &slot, NULL, bank_pool );
if( FD_UNLIKELY( !bank ) ) {
FD_LOG_WARNING(( "Failed to get bank" ));
fd_rwlock_unread( &banks->rwlock );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait shouldnt the caller be retaining the read lock here? how does the pointer stay valid on return -- its not a copy?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github's PR UI is idiotic and doesn't let me tag other lines, but referring to line 452 not this

return NULL;
}

Expand Down
Loading