Skip to content

fix: replace funk reference in syscall handler with sysvar cache look… #5526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

beesyst
Copy link

@beesyst beesyst commented Jul 2, 2025

Summary

Refactored the get_sysvar syscall handler to use the sysvar cache instead of direct funk access, ensuring SVM remains pure and decoupled from storage/database APIs.

Scope

  • Affected files: fd_vm_syscall_runtime.c, fd_bank_abi.c
  • All other funk/database references untouched

Reason

Fixes a rare layering violation (see #5030), keeping SVM logic isolated from db/storage code.

Testing

  • Local build and all tests pass
  • Verified all get_sysvar calls use the cache
  • Ran clang-format / linter

@ripatel-fd
Copy link
Contributor

ripatel-fd commented Jul 2, 2025

Thank you for the contribution @beesyst. We are not ready to accept PRs for this area, since we are working on a rather big refactor for sysvar memory management: #5506

@ripatel-fd ripatel-fd closed this Jul 2, 2025
@beesyst
Copy link
Author

beesyst commented Jul 2, 2025

Thank you for the contribution @beesyst. We are not ready to accept PRs for this area, since we are working on a rather big refactor for sysvar memory management: #5506

Got it, thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants