Standardize Dcache Bounds (Issue #826) #5554
Open
+82
−106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ink on every tile
…STEM_CALLBACK_DURING_FRAG
mulupuruvikas
changed the title
ripatel-fd
requested changes
Jul 6, 2025
There was a problem hiding this comment.
This bounds check only works for dcaches with the "compact" allocation strategy (using fd_dcache_compact_next). Zero copy networking requires a different allocation strategy and thus also a different bounds check mechanism, see fd_net_rx_translate_frag. (e.g. on the net->quic link). With this PR, the quic tile now does a bounds check for net RX frags twice (once in stem, once in quic's during_frag callback). It should be possible to unify bounds checks for both alloc strategies.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added dcache bounds checking to src/tango/dcache:fd_dcache_bounds_check. Added this bounds check to fd_stem STEM_CALLBACK_DURING_FRAG macro, and since that is the touchpoint for all demux and dispatching of tiles, I removed the bounds check from all other during_frag occurrences. Unit tests included.