Skip to content

Standardize Dcache Bounds (Issue #826) #5554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mulupuruvikas
Copy link

Added dcache bounds checking to src/tango/dcache:fd_dcache_bounds_check. Added this bounds check to fd_stem STEM_CALLBACK_DURING_FRAG macro, and since that is the touchpoint for all demux and dispatching of tiles, I removed the bounds check from all other during_frag occurrences. Unit tests included.

@mulupuruvikas mulupuruvikas changed the title Standardize Dcache Bounds Standardize Dcache Bounds (Issue #826) Jul 6, 2025
Copy link
Contributor

@ripatel-fd ripatel-fd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bounds check only works for dcaches with the "compact" allocation strategy (using fd_dcache_compact_next). Zero copy networking requires a different allocation strategy and thus also a different bounds check mechanism, see fd_net_rx_translate_frag. (e.g. on the net->quic link). With this PR, the quic tile now does a bounds check for net RX frags twice (once in stem, once in quic's during_frag callback). It should be possible to unify bounds checks for both alloc strategies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants