Skip to content

Conversation

Sharl0tteIsTaken
Copy link

Translate English alt text to Traditional Chinese in the README.

Addresses: #105282

Before submitting this pull request, check the changes to see it's only the changes you made intentionally
If there are changes to other lines you didn't make deliberately, it's possible that your IDE made the changes with a utility like prettier.
Next time, make sure that you only add your changes by using git add -p and rather than git add Contributors.md

If you're doing something in the checklist below, put an x inside [ ] so that - [ ] becomes - [x]

  • I had fun going through this tutorial (ノ^o^)ノ and learned on the way ٩(^◡^)۶
  • There are some things I'd like to improve in this tutorial. I have written them below.
  • There were steps where I had errors while following this tutorial. I have written them below.

Translate English alt text to Traditional Chinese in the README.

Refs: firstcontributions#105282
@Sharl0tteIsTaken
Copy link
Author

Hi! I've submitted a PR for issue #105282. Please let me know if I need to make any changes. Thanks!

@rammba
Copy link
Member

rammba commented Oct 15, 2025

Hello @Sharl0tteIsTaken, welcome to the GitHub. Thanks for your first contribution 🚀

In order to properly mark issue as closed and prevent others from closing issues after merging the PR, you can say following in the description:
Instead of Addresses #105282, you should say Closes #105282, Fixes #105282 or Resolves #105282.

@Sharl0tteIsTaken
Copy link
Author

Hello @rammba,

Thanks for pointing this out, but I'm a bit confused here, so do I need to edit the PR comment or is it too late and I need to do something else to fix this?

Sorry, I'm new to this, I've done some digging and find a github document (Linking a pull request to an issue) that shows how to manually linking a pull request to an issue using the pull request sidebar and manually linking a pull request or branch to an issue using the issue sidebar, is this what I need to do?

I use the word 'Addresses' because in issue #105282 (here) says to Submit a pull request and add this in comments - 'Addresses #'.

📋 Steps to solve the problem

  • ...
  • Add, commit, push your changes.
  • Submit a pull request and add this in comments - 'Addresses #' <- here
  • Ask for reviews in comments section of pull request.

I'm not sure what to do from here, please tell me what to do next.
Thank you in advance!

@rammba
Copy link
Member

rammba commented Oct 16, 2025

Hello @Sharl0tteIsTaken, sorry for making a confusion, I wasn't aware of that comment by @Roshanjossey.
Whenever you mention existing PR/issue with #105282 in your PR/issue, you will create a link between your PR/issue and the menitoned one. Linking is not the same as saying that PR will complete some issue. You can see here how to link a PR with an issue and automatically close it when PR is merged.

When you properly link issue and PR with a keyword, you will see message like this in the issue:
image

@Roshanjossey when you create an issue, maybe you can give an advice for keyword Closes instead of Addresses. In that way, you won't need to close issues manually.

@Sharl0tteIsTaken
Copy link
Author

Sharl0tteIsTaken commented Oct 16, 2025

Hello @rammba,

I see, thank you for your explanation. Indeed, there is no message linked ... in the comment section in this PR or #105282. I'll keep this in mind next time when I submit a PR. For now, I think I'll leave this PR as is until @Roshanjossey responds, unless changing the keyword (Addresses) is necessary.

Thanks again for the clarification, and do let me know if there's anything I need to change.
Thank you in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants