adding additional filtering for generic carver #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest binwalk wants an extra `--run-as=root` parameter
|
@jstucke: The next time you build the container binwalk will upgrade and the generic_carver breaks because of the required extra argument. Note: https://github.com/ReFirmLabs/binwalk#-extraction-security-notice- Just wanted to point it out and raise awareness |
|
Marking as draft. I realized that I have some other changes I'd like to upstream, so will make this a Draft at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstreaming changes to improve filtering in the generic carver.
I was seeing a lot of zlib files that ended up being invalid, so those are now filtered out.
additionally, there are cases where binwalk will extract a file that is identical to the original (usually
0.<extension>) which is utterly unhelpful.I also changed the shell command to have a timeout of 10 mins. I was seeing cases where binwalk tried to extract for very long periods of time and ended up producing nothing useful. Happy to change that back if you don't agree with that part of it.