Skip to content

[1.x] [suspend] chore: build typings#4337

Merged
imorland merged 2 commits into1.xfrom
im/missing-typings
Jan 7, 2026
Merged

[1.x] [suspend] chore: build typings#4337
imorland merged 2 commits into1.xfrom
im/missing-typings

Conversation

@imorland
Copy link
Member

@imorland imorland commented Jan 7, 2026

Fixes #0000

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@imorland imorland added this to the 1.8.12 milestone Jan 7, 2026
@imorland imorland requested a review from a team as a code owner January 7, 2026 09:43
@imorland imorland force-pushed the im/missing-typings branch from 66b8727 to 1ae0f15 Compare January 7, 2026 09:44
@imorland imorland merged commit edf3e67 into 1.x Jan 7, 2026
360 checks passed
@imorland imorland deleted the im/missing-typings branch January 7, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant