The exceptions in the exception overview are searchable! #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In screenshots, it looks like there are multiple pages, even when there are only two exceptions queried after filtering. The pagination is probably only considering the full amount of exceptions and not the amount after filtering. We might need to include the filter parameters in the count functions, not only the get functions. |
Carmish
reviewed
Mar 10, 2025
Carmish
approved these changes
Mar 10, 2025
NatalieClaraPetersen
requested changes
Mar 11, 2025
AlbertRossJoh
force-pushed
the
feature/exn-monitoring-search
branch
from
5da52ca to
257dc7d
Compare
NatalieClaraPetersen
requested changes
Mar 11, 2025
|
|
||
| const getQueryString = function () { | ||
| removeUnwelcomeParameters(); | ||
| let query = decodeURI(window.location.search); |
There was a problem hiding this comment.
Maybe use the object new URLSearchParams(window.location.search)? It has the .keys() function that could save us some splits and parsing maybe?
Otherwise everything looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user can now search/filter exceptions in the exception overview.
The specific filters can also be specified in the search box
How it looks