Skip to content

feat: added options to customize double-tap (drag) zoom gestures #2070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 4, 2025

Conversation

JaffaKetchup
Copy link
Member

Continuation of #2068. The original PR was not suitable for merging without significant work and was not open for editing by maintainers. I also took the opportunity to introduce some other new options.

Now, it's possible to change the amount by which the double-tap-drag zoom gesture works, and the duration and curve of the normal double tap zoom gesture. I've also changed the default curve for this animation from linear to fastOutSlowIn, which is more similar to what can be expected from other mobile map apps.

Thanks for the initial idea @Quirille.

Added `InteractionOptions.doubleTapDragZoomFactor`
Added `.doubleTapZoomDuration`
Added `.doubleTapZoomCurve`
@JaffaKetchup JaffaKetchup requested a review from a team April 6, 2025 13:45
Updated example app dependency

Co-authored-by: Kiril Tijsma <kiril@live.nl>
Co-authored-by: Freek van de Ven <freek@freekvandeven.nl>
@JaffaKetchup
Copy link
Member Author

Just as a reference: #2068 (comment).

I hope I did not insult anyone, and I apologise if I did. We'd be more than happy to accept contributions again!

@JaffaKetchup JaffaKetchup changed the title feat: added more options to customize double-tap (drag) zoom gestures feat: added options to customize double-tap (drag) zoom gestures Apr 7, 2025
@tobiasleijs
Copy link

@josxha could you review this pull request?

@JaffaKetchup JaffaKetchup requested a review from a team April 29, 2025 18:47
Copy link
Contributor

@josxha josxha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the long wait for a code review, looks good to me.

@JaffaKetchup JaffaKetchup enabled auto-merge (squash) May 4, 2025 21:18
@JaffaKetchup JaffaKetchup merged commit 129e51b into master May 4, 2025
7 checks passed
@JaffaKetchup JaffaKetchup deleted the double-tap-zoom-flexibility branch May 4, 2025 21:20
@JaffaKetchup
Copy link
Member Author

Thanks again @Quirille & @freekvandeven :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants