-
-
Notifications
You must be signed in to change notification settings - Fork 881
feat: added options to customize double-tap (drag) zoom gestures #2070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added `InteractionOptions.doubleTapDragZoomFactor` Added `.doubleTapZoomDuration` Added `.doubleTapZoomCurve`
Updated example app dependency Co-authored-by: Kiril Tijsma <kiril@live.nl> Co-authored-by: Freek van de Ven <freek@freekvandeven.nl>
Just as a reference: #2068 (comment). I hope I did not insult anyone, and I apologise if I did. We'd be more than happy to accept contributions again! |
@josxha could you review this pull request? |
…to external parameter
…ator` callback parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the long wait for a code review, looks good to me.
Thanks again @Quirille & @freekvandeven :) |
Continuation of #2068. The original PR was not suitable for merging without significant work and was not open for editing by maintainers. I also took the opportunity to introduce some other new options.
Now, it's possible to change the amount by which the double-tap-drag zoom gesture works, and the duration and curve of the normal double tap zoom gesture. I've also changed the default curve for this animation from linear to
fastOutSlowIn
, which is more similar to what can be expected from other mobile map apps.Thanks for the initial idea @Quirille.