narrowphase distance: fix signed distance when touching #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case of mesh or octree distance checks, we do a collision after distance checking when doing signed distance to find penetration depth. However, the maximum penetration depth was initialized to numeric limits min, which is slightly greater than zero. If the only contact is exactly 0.0 depth, the code fails. Fix this to the negative max.
c-andy-martin
force-pushed
the
fix-narrowphase-signed-distance-when-touching
branch
from
f992f1f to
f42164c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of mesh or octree distance checks, we do a collision
after distance checking when doing signed distance to find
penetration depth. However, the maximum penetration depth was
initialized to numeric limits min, which is slightly greater than
zero. If the only contact is exactly 0.0 depth, the code fails.
Fix this to the negative max.
This change is