Skip to content

Fix wrong animation confirm setup #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 3, 2024
Merged

Fix wrong animation confirm setup #933

merged 5 commits into from
Sep 3, 2024

Conversation

makeevrserg
Copy link
Member

Background

On setup screen of infrared remotes bottom sheet animation has bad behaviour on state change

Changes

  • Use transitions to implement target state and current state for bottom sheet animation

Test plan

  • Open setup screen
  • Press button, waith for bottom sheet opened with beautiful animation
  • Click yes or no and see another beautiful close animation

@makeevrserg makeevrserg requested a review from LionZXY as a code owner September 3, 2024 09:46
LionZXY
LionZXY approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@LionZXY LionZXY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Amazing, thank you!

@makeevrserg makeevrserg added this pull request to the merge queue Sep 3, 2024
Merged via the queue into flipperdevices:dev with commit 72dac16 Sep 3, 2024
9 checks passed
@makeevrserg makeevrserg deleted the fix/wrong-animation-confirm-setup branch September 3, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LionZXY LionZXY LionZXY approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@makeevrserg @LionZXY