Skip to content

Conversation

bettse
Copy link
Contributor

@bettse bettse commented Apr 4, 2025

Application Submission

  • Seos compatible reader/emulator (NFC/BLE)

Extra Requirements

Author Checklist (Fill this out)

  • I've read the contribution guidelines and my PR follows them
  • I own the code I'm submitting or have code owner's permission to submit it
  • I have validated the manifest file(s) with python3 tools/bundle.py --nolint applications/CATEGORY/APPID/manifest.yml bundle.zip

Reviewer Checklist (Don't fill this out)

  • Bundle is valid
  • There are no obvious issues with the source code
  • I've ran this application and verified its functionality

@doomwastaken doomwastaken self-assigned this Apr 6, 2025
@doomwastaken doomwastaken added app (new) QA pending To be reviewed by QA labels Apr 6, 2025
@doomwastaken
Copy link
Member

doomwastaken commented Apr 6, 2025

Edit: Gretings! Will keep PR open and test it once all is merged

@doomwastaken doomwastaken added Awaiting Merges Depends on dev branch or non-merged PRs and removed QA pending To be reviewed by QA labels Apr 6, 2025
@bettse
Copy link
Contributor Author

bettse commented Apr 6, 2025

Edit: Gretings! Will keep PR open and test it once all is merged

Awesome; feel free to also make it draft if that is any easier to manage.

@doomwastaken doomwastaken added QA pending To be reviewed by QA and removed Awaiting Merges Depends on dev branch or non-merged PRs labels Apr 14, 2025
@doomwastaken
Copy link
Member

Seems like "changelog" vs "CHANGELOG"

@bettse
Copy link
Contributor Author

bettse commented Apr 14, 2025

Fixed! Might be worth making a note that the tools/bundle.py should also check for this. I don't think it showed an error before (though I didn't test before fixing it, so I can't be 100% certain)

@doomwastaken doomwastaken merged commit b1b96c1 into flipperdevices:main Apr 14, 2025
6 checks passed
@bettse bettse deleted the bettse/seos_1.0 branch April 14, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (new) QA pending To be reviewed by QA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants