Skip to content

Fixes Mouse Clicker Should have a "0" value setting for "as fast as possible" #3876 #3894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 14, 2024
Merged

Fixes Mouse Clicker Should have a "0" value setting for "as fast as possible" #3876 #3894

merged 3 commits into from
Oct 14, 2024

Conversation

sumukhj1219
Copy link
Contributor

@sumukhj1219 sumukhj1219 commented Sep 12, 2024 •
edited by skotopes
Loading

What's new

  • HID App: allow 0 in mouse clicker, treat it as max rate

Verification

  • Check BLE/USB Remote apps

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@skotopes
Copy link
Contributor

@sumukhj1219 I've pushed couple changes to your PR:

  • delay in timer callback make no sense, instead you can adjust interval
  • BLE HID events reporting got it's own limitations, exceeding 100 events per second will cause issues
  • I've limited max events to 100/s, more is possible but system will be unstable

@skotopes skotopes merged commit d9d3867 into flipperdevices:dev Oct 14, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

1 more reviewer

@skotopes skotopes skotopes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sumukhj1219 @skotopes