nfc/clipper: Update BART station codes #3937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the NFC Clipper card plugin, update the BART station codes for two newer East Bay stations (Milpitas, and Berryessa/North San Jose), and correct the station code for Castro Valley. These station ids come from visiting the stations and checking what id they presented as in the Clipper card data.
ted-logan
requested review from
Astrrra,
DrZlo13,
gornekich,
gsurkov,
hedger and
skotopes
as code owners
skotopes
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the NFC Clipper card plugin, update the BART station codes for two newer East Bay stations (Milpitas, and Berryessa/North San Jose), and correct the station code for Castro Valley. These station ids come from visiting the stations and checking what id they presented as in the Clipper card data.
What's new
Verification
To fully verify this would require tagging in and out at these three BART stations. I did this with my real Clipper card and read it with my Flipper Zero afterwards. Here's a screenshot of a ride I took on BART (in the San Francisco Bay Area) from Berryessa/North San Jose to Milpitas, on Sunday afternoon (Pacific time), running with my code change to fill in the station codes:
And a second ride I took, from Milpitas to Castro Valley:
On the released firmware, the Berryessa and Milpitas stations show as "Unknown", and the Castro Valley station shows as "Daly City(2)?".
Checklist (For Reviewer)