nfc/clipper: #3991
Merged
nfc/clipper: #3991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the BART station ids for the San Lorenzo and Bay Fair stations in the East Bay of the San Francisco Bay Area.
Add MUNI station ids for the T line "Central Subway" project, which opened three new underground stations in 2022.
ted-logan
requested review from
Astrrra,
DrZlo13,
gornekich,
gsurkov,
hedger and
skotopes
as code owners
Contributor
|
@ted-logan Nice work.
I checked the card, unfortunately there are no records for those BART or Muni stops. Nonetheless, based on both #3937 and #3969, these changes LGTM. |
skotopes
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
Verification
To verify this requires specific rides on San Francisco Bay Area transit with a Clipper card. Maybe @tomholford has been to some of these stations recently since we're now tagging each other in our pull requests :)
MUNI records only the entering station, and doesn't require tagging off to exit the system or complete a trip. Here's a screenshot viewing my Clipper card record of tagging into Chinatown - Rose Pak Station:
Before my change, this station showed up as "Unknown (001a)"
Tagging into Union Square / Market Street Station:
Tagging into Yerba Buena/Moscone Station
BART records both the entry and exit stations. Here's a screenshot viewing my Clipper card record of a trip from Bay Fair north one stop to San Leandro:
Before my change, the San Leandro station id was incorrect so the trip was incorrectly reported as starting at San Leandro and ending at "Unknown (0020)".
Checklist (For Reviewer)