nfc: Fix MIFARE Plus detection #4049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MIFARE Plus original doesn't have GetVersion support, so detection for SL2 has been moved. Also, SL2 only exists in MIFARE Plus X, so despite it not being specified in the type identification procedure chart, it's safe to call it for what it is.
GMMan
requested review from
skotopes,
DrZlo13,
hedger,
gsurkov,
gornekich and
Astrrra
as code owners
skotopes
previously approved these changes
Jan 12, 2025
skotopes
approved these changes
Jan 12, 2025
Akiva-Cohen
pushed a commit
to Akiva-Cohen/flipperzero-firmware
that referenced
this pull request
Jan 14, 2025
* nfc: Fix MIFARE Plus detection MIFARE Plus original doesn't have GetVersion support, so detection for SL2 has been moved. Also, SL2 only exists in MIFARE Plus X, so despite it not being specified in the type identification procedure chart, it's safe to call it for what it is. * Fix spelling * TODO: mark as non flipper one Co-authored-by: あく <alleteam@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
Due to the lack of public documentation, I can only use what I've observed from the one MFP EV1 sample that I have, so the GetVersion detection is very conservative and does not attempt to fetch the entire version info. This should be good enough to at least identify the type of card.
Verification
Checklist (For Reviewer)