Skip to content

[FL-3957] EventLoop unsubscribe fix #4109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 16, 2025
Merged

[FL-3957] EventLoop unsubscribe fix #4109

merged 3 commits into from
Feb 16, 2025

Conversation

portasynthinca3
Copy link
Member

@portasynthinca3 portasynthinca3 commented Feb 13, 2025 •
edited by skotopes
Loading

What's new

  • Unsubscribing from within an EventLoop callback doesn't crash anymore (fix by gsurkov)
  • Unit test for the fix

Verification

  • Run unit tests

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@portasynthinca3 portasynthinca3 added Bug Core+Services HAL, furi & core system services labels Feb 13, 2025
@github-actions GitHub Actions
Copy link

Compiled f7 firmware for commit e4423755:

@portasynthinca3 portasynthinca3 marked this pull request as ready for review February 13, 2025 20:44
@portasynthinca3 portasynthinca3 mentioned this pull request Feb 13, 2025
Merged
3 tasks
@skotopes skotopes merged commit 4895ae5 into dev Feb 16, 2025
11 checks passed
@skotopes skotopes deleted the portasynthinca3/3957-eventloop-fixes branch February 16, 2025 21:57
@portasynthinca3 portasynthinca3 restored the portasynthinca3/3957-eventloop-fixes branch March 12, 2025 20:47
@portasynthinca3 portasynthinca3 deleted the portasynthinca3/3957-eventloop-fixes branch March 13, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra

@Skorpionm Skorpionm Awaiting requested review from Skorpionm Skorpionm is a code owner

1 more reviewer

@skotopes skotopes skotopes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bug Core+Services HAL, furi & core system services

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@portasynthinca3 @skotopes @gsurkov