Skip to content

Stricter constness for const data #4126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Mar 31, 2025
Merged

Stricter constness for const data #4126

merged 12 commits into from
Mar 31, 2025

Conversation

hedger
Copy link
Member

@hedger hedger commented Feb 22, 2025 •
edited
Loading

What's new

  • libs: stricter constness for saving RAM by using .rodata section (thus, flash memory) for object storage;
  • hal: made FuriHalSpiBusHandle, FuriHalI2cBusHandle const across API methods
  • fbt: sdk: fixed signature generation for types with nested constness
  • saves about 1K RAM in release builds - see size report for details
f7
this branch
	.data            796 (  0.78 K)
dev
	.data           1776 (  1.73 K)

sidenote: furi_hal_usb_set_state_callback future?

Verification

  • Build, flash, everything should work - no functional changes

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@hedger
libs: stricter constness for saving RAM with .rodata section; fbt: sd…
b083522 
…k: fixed signature generation for nested const params
@hedger hedger added Build System & Scripts fbt, scripts and toolchain-related Core+Services HAL, furi & core system services labels Feb 22, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 22, 2025 •
edited
Loading

Compiled f7 firmware for commit 4c4a253f:

@hedger hedger marked this pull request as draft February 22, 2025 19:25
@hedger hedger marked this pull request as ready for review February 22, 2025 19:53
@hedger hedger merged commit 5fcaef2 into dev Mar 31, 2025
10 of 11 checks passed
@hedger hedger deleted the hedger/more-constness branch March 31, 2025 15:23
hedger added a commit to RebornedBrain/flipperzero-firmware that referenced this pull request Apr 5, 2025
@hedger
Stricter constness for const data (flipperdevices#4126)
8080565 
* libs: stricter constness for saving RAM with .rodata section; fbt: sdk: fixed signature generation for nested const params

* hal: additional fixes for constness in USB subsystem

* debug apps: additional usb-related fixes

* mjs: more consts for token parser

* fatfs: const driver struct

* hal: more consts for ble & nfc vars

* hal: made FuriHalSpiBusHandle static

* hal: made FuriHalI2cBusHandle static

* usb: restored previous api

* linter fixes

* API fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsurkov gsurkov gsurkov approved these changes

@skotopes skotopes Awaiting requested review from skotopes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@Skorpionm Skorpionm Awaiting requested review from Skorpionm Skorpionm is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

@Astrrra Astrrra Awaiting requested review from Astrrra

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

@portasynthinca3 portasynthinca3 Awaiting requested review from portasynthinca3 portasynthinca3 is a code owner

Assignees
No one assigned
Labels
Build System & Scripts fbt, scripts and toolchain-related Core+Services HAL, furi & core system services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hedger @gsurkov