Skip to content

[FL-3963] Move modules to new arg parser #4139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Apr 4, 2025
Merged

[FL-3963] Move modules to new arg parser #4139

merged 25 commits into from
Apr 4, 2025

Conversation

portasynthinca3
Copy link
Member

@portasynthinca3 portasynthinca3 commented Mar 5, 2025 •
edited by hedger
Loading

What's new

  • Moved some JS modules to the new arg parser: event_loop, storage, gui, gui/file_picker, gui/icon, gpio, serial
  • As a result, reduced the code size of these modules, leading to reduced RAM usage: 
    +-----------------+-------+-------+--------+
| JS Module       |  New  |  Old  | Change |
+-----------------+-------+-------+--------|
| event_loop      | 3568  | 4744  | -25%   |
| storage         | 9104  | 14712 | -38%   |
| gui             | 5632  | 7616  | -26%   |
| gui/file_picker | 541   | 829   | -35%   |
| gui/icon        | 1513  | 2041  | -26%   |
| gpio            | 4596  | 6136  | -25%   |
| serial          | 6124  | 8596  | -29%   |
+-----------------+-------+-------+--------+
| total           | 31078 | 44674 | -30%   |
+-----------------+-------+-------+--------+
    The net flash usage increase is 128 bytes. The new parser is about 1700 bytes, but that is mostly offset due to the in-flash modules being moved to the new parser as well.

Verification

  • Run unit tests
  • Run the gpio, uart_echo, uart_echo_8e1 and gui demo scripts and verify that they work as intended

Remarks

This PR depends on #4135, please review and merge it before this one.

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@portasynthinca3
js: value destructuring and tests
20294a8
@portasynthinca3
js: temporary fix to see size impact
f51d726
@portasynthinca3
js_val: reduce code size 1
ca0fc5f
@portasynthinca3
i may be stupid.
74700ce
@portasynthinca3
test: js_value args
cca650e
@portasynthinca3
Revert "js: temporary fix to see size impact"
11b82c0 
This reverts commit f51d726.
@portasynthinca3
pvs: silence warnings
4a69443
@portasynthinca3
style: formatting
35d500d
@portasynthinca3
pvs: silence warnings?
4d9d1c6
@portasynthinca3
pvs: silence warnings??
1c3f2e3
@portasynthinca3
js_value: redesign declaration types for less code
e59eed4
@portasynthinca3
js: temporary fix to see size impact
d6a46f0
@portasynthinca3
style: formatting
541ea2a
@portasynthinca3
pvs: fix helpful warnings
245800e
@portasynthinca3
js_value: reduce .rodata size
e1f7a78
@portasynthinca3
pvs: fix helpful warning
7a9b0a9
@portasynthinca3
js_value: reduce code size 1
bccc4f4
@portasynthinca3
fix build error
6b6ea5d
@portasynthinca3
style: format
b5a1f95
@portasynthinca3
Revert "js: temporary fix to see size impact"
eb075f7 
This reverts commit d6a46f0.
@portasynthinca3
style: format
544193e
@portasynthinca3
js: move to new arg parser
49e5649
@portasynthinca3
style: format
db899d4
@portasynthinca3 portasynthinca3 added the JS JS Runtime, loader and API label Mar 5, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 5, 2025 •
edited
Loading

Compiled f7 firmware for commit 71dff656:

@portasynthinca3 portasynthinca3 marked this pull request as ready for review March 5, 2025 08:35
@portasynthinca3 portasynthinca3 mentioned this pull request Mar 5, 2025
Merged
3 tasks
@portasynthinca3 portasynthinca3 mentioned this pull request Mar 24, 2025
Merged
3 tasks
@hedger hedger merged commit dac1457 into dev Apr 4, 2025
11 checks passed
@hedger hedger deleted the portasynthinca3/3963-js-use-js_value branch April 4, 2025 23:17
hedger added a commit to RebornedBrain/flipperzero-firmware that referenced this pull request Apr 5, 2025
@portasynthinca3 @hedger
[FL-3963] Move JS modules to new arg parser (flipperdevices#4139)
27113de 
* js: value destructuring and tests

* js: temporary fix to see size impact

* js_val: reduce code size 1

* i may be stupid.

* test: js_value args

* Revert "js: temporary fix to see size impact"

This reverts commit f51d726.

* pvs: silence warnings

* style: formatting

* pvs: silence warnings?

* pvs: silence warnings??

* js_value: redesign declaration types for less code

* js: temporary fix to see size impact

* style: formatting

* pvs: fix helpful warnings

* js_value: reduce .rodata size

* pvs: fix helpful warning

* js_value: reduce code size 1

* fix build error

* style: format

* Revert "js: temporary fix to see size impact"

This reverts commit d6a46f0.

* style: format

* js: move to new arg parser

* style: format

---------

Co-authored-by: hedger <hedger@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedger hedger hedger approved these changes

@skotopes skotopes Awaiting requested review from skotopes

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

@gornekich gornekich Awaiting requested review from gornekich

@Astrrra Astrrra Awaiting requested review from Astrrra

@Skorpionm Skorpionm Awaiting requested review from Skorpionm

Assignees
No one assigned
Labels
JS JS Runtime, loader and API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@portasynthinca3 @hedger