Skip to content

Add date/time input module #4261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: dev
Choose a base branch
from
Open

Add date/time input module #4261

wants to merge 11 commits into from
+914 −0

Conversation

aaronjamt
Copy link

What's new

  • Adds a new GUI input module to input a date and time

Verification

  • Use this module in an app

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@aaronjamt
Update Date/Time Input GUI module
65cd636 
Add an option to control which fields can be edited by the user
@aaronjamt aaronjamt mentioned this pull request Sep 10, 2025
Closed
2 tasks
hedger
hedger requested changes Sep 23, 2025
View reviewed changes
Copy link
Member

@hedger hedger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a demo app in examples showcasing the new module

@aaronjamt aaronjamt requested a review from hedger September 23, 2025 17:16
hedger
hedger requested changes Sep 23, 2025
View reviewed changes
Copy link
Member

@hedger hedger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks and works really nice - however, we have a system setting for time format, 12/24hours. I think it would be reasonable for the date+time input module to respect the system's configuration. Could you please also implement that?

Also, please update API symbols for f18 too (build with ./fbt TARGET_HW=18)

@aaronjamt
Copy link
Author

aaronjamt commented Sep 23, 2025 •
edited
Loading

Thank you, looks and works really nice - however, we have a system setting for time format, 12/24hours. I think it would be reasonable for the date+time input module to respect the system's configuration. Could you please also implement that?

Also, please update API symbols for f18 too (build with ./fbt TARGET_HW=18)

Should be good now! I'm not sure I like how the 12-hour mode displays, but I'm probably being too nitpicky. I'll see if I can improve it before you review it next, if not then I'll leave it.

Edit: Fixed it, LGTM!

@aaronjamt aaronjamt requested a review from hedger September 23, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@gsurkov gsurkov Awaiting requested review from gsurkov gsurkov is a code owner

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

@hedger hedger Awaiting requested review from hedger hedger is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronjamt @hedger