Skip to content

Conversation

noproto
Copy link
Contributor

@noproto noproto commented Oct 4, 2025

What's new

  • Fixes regression in e7634d7 causing EV1 PWD to no longer be returned with auth manual/auth with reader

Verification

  • Authenticate with reader with an EV1 tag, verify password unlocks tag successfully
  • Authenticate manually with an EV1 tag, verify password unlocks tag successfully
  • Run UL-C dictionary attack with a known key, verify key is found
  • Unlock tag manually with UL-C key, verify it unlocks

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@zinongli
Copy link
Contributor

zinongli commented Oct 4, 2025

I tested this ony my EV 11 tag. The bug was present in 1.40-rc. It's fixed by this PR. Auth with reader and auth manually both work now.

@mishamyte
Copy link
Contributor

Hey @noproto,

Sorry, don't have corresponding role in DC, so will answer here.

Nope, ur fix doesn't work with regression bug I highlighted.

I think for that bug we will need the similar solution as we had in the original fix (reading pages 1 by 1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants