Skip to content

ads show first time only #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ads show first time only #235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
168 changes: 113 additions & 55 deletions src/android/AdMob.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

import android.util.Log;
import android.view.View;
import android.view.View.OnLayoutChangeListener;
import android.view.ViewGroup;
import android.widget.RelativeLayout;
import android.os.Bundle;
Expand All @@ -29,11 +30,13 @@
* This plugin can be used to request AdMob ads natively via the Google AdMob SDK.
* The Google AdMob SDK is a dependency for this plugin.
*/
public class AdMob extends CordovaPlugin {
public class AdMob extends CordovaPlugin implements OnLayoutChangeListener {
/** The adView to display to the user. */
private AdView adView;
private AdView adView = null;
private AdRequest adRequest = null;
private boolean adShow = true;

/** The interstitial ad to display to the user. */
/** The interstitial ad to display to the user. */
private InterstitialAd interstitialAd;

/** if want banner view overlap webview, we will need this layout */
Expand Down Expand Up @@ -80,6 +83,7 @@ public class AdMob extends CordovaPlugin {
*/
@Override
public boolean execute(String action, JSONArray inputs, CallbackContext callbackContext) throws JSONException {

PluginResult result = null;
if (ACTION_CREATE_BANNER_VIEW.equals(action)) {
result = executeCreateBannerView(inputs, callbackContext);
Expand Down Expand Up @@ -141,78 +145,127 @@ private PluginResult executeCreateBannerView(JSONArray inputs, CallbackContext c
Log.w(LOGTAG, String.format("Got JSON Exception: %s", exception.getMessage()));
return new PluginResult(Status.JSON_EXCEPTION);
}


final AdMob thisplugin = this;
final CallbackContext delayCallback = callbackContext;
cordova.getActivity().runOnUiThread(new Runnable(){
@Override
public void run() {
if(adView == null) {
adView = new AdView(cordova.getActivity());
adView.setAdUnitId(publisherId);
adView.setAdSize(adSize);
adView.setAdListener(new BannerListener());
}
if (adView.getParent() != null) {
((ViewGroup)adView.getParent()).removeView(adView);
}
if(bannerOverlap) {
ViewGroup parentView = (ViewGroup) webView;

adViewLayout = new RelativeLayout(cordova.getActivity());
RelativeLayout.LayoutParams params = new RelativeLayout.LayoutParams(
RelativeLayout.LayoutParams.MATCH_PARENT,
RelativeLayout.LayoutParams.MATCH_PARENT);
parentView.addView(adViewLayout, params);

RelativeLayout.LayoutParams params2 = new RelativeLayout.LayoutParams(
RelativeLayout.LayoutParams.MATCH_PARENT,
RelativeLayout.LayoutParams.WRAP_CONTENT);
params2.addRule(bannerAtTop ? RelativeLayout.ALIGN_PARENT_TOP : RelativeLayout.ALIGN_PARENT_BOTTOM);
adViewLayout.addView(adView, params2);

} else {
ViewGroup parentView = (ViewGroup) webView.getParent();
if (bannerAtTop) {
parentView.addView(adView, 0);
} else {
parentView.addView(adView);
thisplugin.createBannerView();

if(adView != null) {
View parentView = (View) adView.getParent();
if(parentView != null) {
parentView.addOnLayoutChangeListener( thisplugin );
}
}
delayCallback.success();
delayCallback.success();
} else {

}
}
});

return null;
}

public void createBannerView() {
if(adView == null) {
Log.w(LOGTAG, "creating banner");
adView = new AdView(cordova.getActivity());
adView.setAdUnitId(publisherId);
adView.setAdSize(adSize);
adView.setAdListener(new BannerListener());
}
if (adView.getParent() != null) {
((ViewGroup)adView.getParent()).removeView(adView);
}
if(bannerOverlap) {
ViewGroup parentView = (ViewGroup) webView;

adViewLayout = new RelativeLayout(cordova.getActivity());
RelativeLayout.LayoutParams params = new RelativeLayout.LayoutParams(
RelativeLayout.LayoutParams.MATCH_PARENT,
RelativeLayout.LayoutParams.MATCH_PARENT);
parentView.addView(adViewLayout, params);

RelativeLayout.LayoutParams params2 = new RelativeLayout.LayoutParams(
RelativeLayout.LayoutParams.MATCH_PARENT,
RelativeLayout.LayoutParams.WRAP_CONTENT);
params2.addRule(bannerAtTop ? RelativeLayout.ALIGN_PARENT_TOP : RelativeLayout.ALIGN_PARENT_BOTTOM);
adViewLayout.addView(adView, params2);

} else {
ViewGroup parentView = (ViewGroup) webView.getParent();
if (bannerAtTop) {
parentView.addView(adView, 0);
} else {
parentView.addView(adView);
}
}
}

public void destroyBannerView() {
if (adView != null) {
ViewGroup parentView = (ViewGroup)adView.getParent();
if(parentView != null) {
Log.w(LOGTAG, "removing banner");
parentView.removeView(adView);
}
adView.setAdListener(null);
adView = null;
}
if (adViewLayout != null) {
ViewGroup parentView = (ViewGroup)adViewLayout.getParent();
if(parentView != null) {
parentView.removeView(adViewLayout);
}
adViewLayout = null;
}
}

private PluginResult executeDestroyBannerView(CallbackContext callbackContext) {
Log.w(LOGTAG, "executeDestroyBannerView");

final AdMob thisplugin = this;
final CallbackContext delayCallback = callbackContext;
cordova.getActivity().runOnUiThread(new Runnable() {
@Override
public void run() {
if (adView != null) {
ViewGroup parentView = (ViewGroup)adView.getParent();
if(parentView != null) {
parentView.removeView(adView);
}
adView = null;
}
if (adViewLayout != null) {
ViewGroup parentView = (ViewGroup)adViewLayout.getParent();
if(parentView != null) {
parentView.removeView(adViewLayout);
}
adViewLayout = null;
}
thisplugin.destroyBannerView();
delayCallback.success();
}
});

return null;
}

@Override
public void onLayoutChange(View v,
int left, int top, int right, int bottom,
int oldLeft, int oldTop, int oldRight, int oldBottom) {
int width = right - left;
int oldWidth = oldRight - oldLeft;
// screen orientation changed ?
Log.w(LOGTAG, String.format("width: %d -> %d", oldWidth, width));
if((v == adView.getParent()) && (width != oldWidth)) {
// re-create banner view
if(adView != null) {
final AdMob thisplugin = this;
final AdRequest lastRequest = adRequest;
cordova.getActivity().runOnUiThread(new Runnable(){
@Override
public void run() {
thisplugin.destroyBannerView();
thisplugin.createBannerView();

if(adView != null && adRequest != null) {
adView.loadAd( lastRequest );
}
}
});
}
}
}

/**
* Parses the create interstitial view input parameters and runs the create interstitial
Expand Down Expand Up @@ -321,10 +374,13 @@ private PluginResult executeRequestAd(JSONArray inputs, CallbackContext callback
cordova.getActivity().runOnUiThread(new Runnable() {
@Override
public void run() {
if (adType.equals("banner"))
if (adType.equals("banner")) {
adView.loadAd(request);
else if (adType.equals("interstitial"))
// we keep this request, needed when re-create banner
adRequest = request;
} else if (adType.equals("interstitial")) {
interstitialAd.loadAd(request);
}

delayCallback.success();
}
Expand Down Expand Up @@ -358,6 +414,8 @@ private PluginResult executeShowAd(JSONArray inputs, CallbackContext callbackCon
return new PluginResult(Status.JSON_EXCEPTION);
}

adShow = show;

if(adView == null) {
return new PluginResult(Status.ERROR, "adView is null, call createBannerView first.");
}
Expand Down Expand Up @@ -388,8 +446,8 @@ public class BasicListener extends AdListener {
@Override
public void onAdFailedToLoad(int errorCode) {
webView.loadUrl(String.format(
"javascript:cordova.fireDocumentEvent('onFailedToReceiveAd', { 'error': %d, 'reason':'%s' });",
errorCode, getErrorReason(errorCode)));
"javascript:cordova.fireDocumentEvent('onFailedToReceiveAd', { 'error': %d, 'reason':'%s' });",
errorCode, getErrorReason(errorCode)));
}

@Override
Expand All @@ -412,6 +470,7 @@ private class BannerListener extends BasicListener {
@Override
public void onAdLoaded() {
Log.w("AdMob", "BannerAdLoaded");
adView.setVisibility( adShow ? View.VISIBLE : View.GONE );
webView.loadUrl("javascript:cordova.fireDocumentEvent('onReceiveAd');");
}
}
Expand Down Expand Up @@ -473,7 +532,6 @@ public static AdSize adSizeFromString(String size) {
return null;
}
}


/** Gets a string error reason from an error code. */
public String getErrorReason(int errorCode) {
Expand Down