The source distribution is missing a file used in setup.py

[ocefpaf]

I was about to send a PR to add the requirements.txt file to the MANIFEST when I saw these lines:

https://github.com/flosell/trailscraper/blob/master/setup.py#L4-L11

Is that by design? To not add any dependency when installing from a source distribution? If so, why? If not, I can send a PR to fix it.

[flosell]

Hi @ocefpaf - to be honest, one of the reasons I picked python for this project was because I wanted to learn the language at that point. It never became my main ecosystem to work in so there's a very good chance something's horribly weird about the way I'm putting this together :)

That being said, I'm not quite sure I understand the issue or proposal.
Is the way things are currently done breaking a particular use-case? If yes, can you provide some description?
Or is it more of a question of aesthetics, conventions and tech debt? In which case, what would the benefits and drawbacks of changing things be? What would it look like?

[ocefpaf]

horribly weird about the way I'm putting this together :)

To be fair Python experts do the same. (I'm guilty of it that sometimes.)

Is the way things are currently done breaking a particular use-case? If yes, can you provide some description?

Not a broken use-case but, IMO, that is just broken. The requirements.txt is how you read and add the dependencies to the setup.py, so that file should be shipped in the source distribution. When you fail if that files does not exists one does not get any dependencies, they get a broken package. If you are OK I can send a PR with Python's modern "best practices" for this.

[flosell]

Thanks for the offer! I'm always happy about PRs that improve the project so feel free to send in one with what you feel makes sense!