Skip to content

Commit a2093ba

Browse files
dev-slattodcarley
authored andcommitted
chore(logic): Runner should be removed before termination
The EC2 instance should be marked as unschedulable by Github Actions before termination to make sure that Github Actions dosen't schedule any jobs to it while it's being terminated. Cherry-pick of: - machulav#161 This seems to be solving the same problem as the `--ephemeral` argument in the preceding commit but I'm deep enough in this yak shave that I don't want to debug which one works better right now.
1 parent d5ddd89 commit a2093ba

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ async function start() {
2525
}
2626

2727
async function stop() {
28-
await aws.terminateEc2Instance();
2928
await gh.removeRunner();
29+
await aws.terminateEc2Instance();
3030
}
3131

3232
(async function () {

0 commit comments

Comments
 (0)