feat(air-interpreter)!: rkyv-serialized JValues #814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of `anyhow`, use `eyre` to reduce number of deps. The `eyre` crate is already used in `avm-server` and `fluence-keypair`.
It is run with 10Mb stack, not 8Mb stack
The stack size if 10mb for convenience.
After introducing cheap-to-clone JValue and removing Cows, it is same as `JValuable::as_jvalue`.
Constant strings that are converted to JSON values are stored as `JsonStrings`. It saves on memory allocations.
After removing Cows, their names make no sense.
It is not needed anymore
monoid
added
P-high
added 9 commits
February 8, 2024 14:40
It fixes sudden failed compilation because of 3rd party library changes.
It makes it more efficient and avoid buggy rkyv BTree serialization/validation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It preserves shared data, and values' data size is not exploded on the serialization.
This change makes data format incompatible with previous versions.