From 7f385b8c323120ba6782ea9d132c2cc108c31867 Mon Sep 17 00:00:00 2001 From: ehdtjs0612 Date: Mon, 14 Oct 2024 15:36:22 +0900 Subject: [PATCH 1/4] fix: Remove unused variable --- lib/processor.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/processor.js b/lib/processor.js index 36d980ad..4e59c10e 100644 --- a/lib/processor.js +++ b/lib/processor.js @@ -2,8 +2,6 @@ 'use strict'; var spawn = require('child_process').spawn; -var path = require('path'); -var fs = require('fs'); var async = require('async'); var utils = require('./utils'); From 09bad0f88a6d25b289b7cabb163f2ed1c7996ed2 Mon Sep 17 00:00:00 2001 From: ehdtjs0612 Date: Mon, 14 Oct 2024 15:39:39 +0900 Subject: [PATCH 2/4] Docs: Add duration to codecData JSDoc --- lib/processor.js | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/processor.js b/lib/processor.js index 4e59c10e..101967a9 100644 --- a/lib/processor.js +++ b/lib/processor.js @@ -66,6 +66,7 @@ module.exports = function(proto) { * @param {String} codecData.audio_details input audio codec parameters * @param {String} codecData.video input video codec name * @param {String} codecData.video_details input video codec parameters + * @param {String} codecData.duration input video duration */ /** From c20f2c96ebaf6ceba95c3c721bf5403bf73110c4 Mon Sep 17 00:00:00 2001 From: ehdtjs0612 Date: Mon, 14 Oct 2024 19:24:03 +0900 Subject: [PATCH 3/4] Feat: add missing properties audio_details --- lib/utils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/utils.js b/lib/utils.js index 96909dbd..907623eb 100644 --- a/lib/utils.js +++ b/lib/utils.js @@ -294,7 +294,7 @@ var utils = module.exports = { inInput = codecsObject.inInput = true; inputIndex = codecsObject.inputIndex = codecsObject.inputIndex + 1; - inputStack[inputIndex] = { format: format[1], audio: '', video: '', duration: '' }; + inputStack[inputIndex] = { format: format[1], audio: '', audio_details: '', video: '', duration: '' }; } else if (inInput && (dur = stderrLine.match(durPattern))) { inputStack[inputIndex].duration = dur[1]; } else if (inInput && (audio = stderrLine.match(audioPattern))) { From f31cd190db915ec0536bef23aee6b6932e2d1464 Mon Sep 17 00:00:00 2001 From: ehdtjs0612 Date: Tue, 15 Oct 2024 17:31:03 +0900 Subject: [PATCH 4/4] Feat: add missing properties video_details --- lib/utils.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/utils.js b/lib/utils.js index 907623eb..ef5ba04c 100644 --- a/lib/utils.js +++ b/lib/utils.js @@ -294,7 +294,7 @@ var utils = module.exports = { inInput = codecsObject.inInput = true; inputIndex = codecsObject.inputIndex = codecsObject.inputIndex + 1; - inputStack[inputIndex] = { format: format[1], audio: '', audio_details: '', video: '', duration: '' }; + inputStack[inputIndex] = { format: format[1], audio: '', audio_details: '', video: '', video_details: '', duration: '' }; } else if (inInput && (dur = stderrLine.match(durPattern))) { inputStack[inputIndex].duration = dur[1]; } else if (inInput && (audio = stderrLine.match(audioPattern))) {