Skip to content

This PR is to add comments to newJindoEngineREP in pkg/ddc/jindo/replicas_test.go.#5014

Closed
lee002k wants to merge 1 commit intofluid-cloudnative:masterfrom
lee002k:new-branch
Closed

This PR is to add comments to newJindoEngineREP in pkg/ddc/jindo/replicas_test.go.#5014
lee002k wants to merge 1 commit intofluid-cloudnative:masterfrom
lee002k:new-branch

Conversation

@lee002k
Copy link

@lee002k lee002k commented Jun 1, 2025 •
edited
Loading

Ⅰ. Describe what this PR does

Add comments to newJindoEngineREP in pkg/ddc/jindo/replicas_test.go.

Ⅱ. Does this pull request fix one issue?

fixes #5013

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@lee002k
Add Notation to newJindoEngineREP in pkg/ddc/jindo/replicas_test.go.
ad7ddf9 
Signed-off-by: lee002k <artelina1906@outlook.com>
@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Jun 1, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign trafalgarzzz for approval by writing /assign @trafalgarzzz in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Jun 1, 2025

Hi @lee002k. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 1, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

needs-ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add comments to newJindoEngineREP in pkg/ddc/jindo/replicas_test.go.

2 participants

@lee002k @TrafalgarZZZ