internal/informer/branch-planner/informer.go: get actual object

Author: akselleirv

internal/informer/branch-planner/informer.go

@@ -148,6 +148,12 @@ func (i *Informer) updateHandler(oldObj, newObj interface{}) {
 
 	ctx := context.Background()
 
+	// The informer cache does not update when the status field is updated, so we need to get the object from api server.
+	if err := i.client.Get(ctx, client.ObjectKeyFromObject(new), new); err != nil {
+		i.log.Info("failed getting object", "namespace", new.Namespace, "name", new.Name, "error", err)
+		return
+	}
+
 	for _, condition := range new.Status.Conditions {
 		if condition.Reason == infrav1.TFExecInitFailedReason || condition.Reason == infrav1.PostPlanningWebhookFailedReason {
 			if ann := new.GetAnnotations(); ann != nil && ann[config.AnnotationErrorRevision] == new.Status.LastAttemptedRevision {

internal/informer/branch-planner/informer_test.go

@@ -108,15 +108,6 @@ func TestInformer(t *testing.T) {
 	tf.Status.LastPlanAt = &metav1.Time{Time: time.Now()}
 	expectToSucceed(t, g, k8sClient.Status().Patch(ctx, tf, patch))
 
-	// verify that the last plan time is updated
-	g.Eventually(func() *metav1.Time {
-		err = k8sClient.Get(ctx, client.ObjectKeyFromObject(tf), tf)
-		if err != nil {
-			return nil
-		}
-		return tf.Status.LastPlanAt
-	}).ShouldNot(gom.BeNil())
-
 	g.Eventually(func() int {
 		return gitProvider.AddCommentToPullRequestCallCount()
 	}).Should(gom.Equal(1))