Skip to content

fixing refocus if reopening already open file #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion crates/rnote-ui/src/appwindow/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -540,6 +540,8 @@ impl RnAppWindow {
anyhow::anyhow!("Could not open file '{input_file:?}', file path is None.")
})?;

// we grab focus
self.present();
// If the file is already opened in a tab, simply switch to it
if let Some(page) = self.tabs_query_file_opened(input_file_path) {
self.overlays().tabview().set_selected_page(&page);
Expand Down Expand Up @@ -570,7 +572,6 @@ impl RnAppWindow {
self.append_wrapper_new_tab(&wrapper);
}
self.handle_widget_flags(widget_flags, &wrapper.canvas());
self.present();
true
}
}
Expand Down