-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
I think the description of the library is fine but I think a little more work could be done contextualizing it. In particular:
- The
Matrix
class provides two things. First, it implements a few different matrix representations (dense, sparse, diagonal, etc.) along with providing a high-level interface for those objects. Because it is written in S4 it is a framework for allowing operations to work with different matrix types. The fmlr package is providing new representations but doesn't address the framework issue. Does your higher-level package implement S4 types that are compatible withMatrix
? - My basis for comparison is the
torch
library. Can you say howfmlr
distinguishes itself fromtorch
. - I know people like to point out that S4 is slow, but is it usually the bottleneck in matrix calculations? My intuition is that it is for small data sets that run quickly anyway. You already know that for larger matrix operations, dispatch has low relative overhead and we'd probably be better off refactoring the matrix operations or figuring out how to get R to do it.
Metadata
Metadata
Assignees
Labels
No labels