fix(bigfile): Fix bigfile detection with symlinks#2652
Open
joshw1013 wants to merge 1 commit intofolke:mainfrom
Open
fix(bigfile): Fix bigfile detection with symlinks#2652joshw1013 wants to merge 1 commit intofolke:mainfrom
joshw1013 wants to merge 1 commit intofolke:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is where the bug is
In the current code, if you open up a file whose path is a symlink (inside of Neovim not from the terminal), the path variable gets the symlink path, while the vim.api.nvim_buf_get_name(buf) returns the target path. This causes a mismatch making the program mistakenly return.
The fix just uses
vim.uv.fs_realpath(path)to translate it to the target pathExample
This is my debugging messages after fixing it for the case that was causing me trouble