feat(extra): add active buffer styling for helix #694
Conversation
archcorsair
changed the title
archcorsair
changed the title
|
I think you have to add this to https://github.com/folke/tokyonight.nvim/blob/main/lua/tokyonight/extra/helix.lua because those extras are generated. |
archcorsair
force-pushed
the
feat/helix-bufferline-active-styles
branch
from
cb63922 to
b617df7
Compare
Hey, you're awesome and I totally missed that. Fixed now. PS: Looks like I shouldn't commit the generated files since those get generated by CI. Fixed that too. |
archcorsair
force-pushed
the
feat/helix-bufferline-active-styles
branch
from
b617df7 to
f2336e9
Compare
archcorsair
force-pushed
the
feat/helix-bufferline-active-styles
branch
from
f2336e9 to
91d4e4e
Compare
|
I only noticed this because I have been trying to figure out why the ruler is rendered incorrectly (not because of your pr) |
I've noticed this too. Does the cursor also get hidden by the indent guide for you? |
|
It does. Something is wrong with this theme that is causing that. The themes that ship with helix don't suffer from these issues.
|
|
This PR is stale because it has been open 30 days with no activity. |
|
Bumping to remove stale tag |
|
This PR is stale because it has been open 30 days with no activity. |
|
Bumping to remove stale tag |
|
@archcorsair helix upstream has tokyonight shipped by default now. https://github.com/helix-editor/helix/blob/ae0dd313bdb418b6944ce77b44023c7fb31b9000/runtime/themes/tokyonight_storm.toml |
Thanks for letting me know! Looks like it's still missing bufferline styling though. |
|
@archcorsair try pushing it up stream, I'm sure other Helix users would like it. I know I would 😄 |
Description
The helix themes currently lack styling for helix bufferline active tabs, which makes it more difficult to see which current buffer tab is active at a glance.
This PR suggests colors for the tab using the current theme's color pallet.
Screenshots
Day
Moon
Night
Storm