W-18078038 - feat: move e2e tests #6179
Open
+17,422
−4,539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternhale
approved these changes
Apr 1, 2025
package.json
Outdated
| @@ -119,7 +132,8 @@ | |||
| "aggregateJUnit": "node scripts/aggregate-junit-xml.js", | |||
| "link-lsp": "yarn link @salesforce/aura-language-server @salesforce/lwc-language-server @salesforce/lightning-lsp-common && lerna exec yarn link @salesforce/aura-language-server @salesforce/lwc-language-server @salesforce/lightning-lsp-common --scope salesforcedx-vscode-lightning && lerna exec yarn link @salesforce/lwc-language-server @salesforce/lightning-lsp-common --scope salesforcedx-vscode-lwc", | |||
| "unlink-lsp": "yarn unlink @salesforce/aura-language-server @salesforce/lwc-language-server @salesforce/lightning-lsp-common && lerna exec yarn unlink @salesforce/aura-language-server @salesforce/lwc-language-server @salesforce/lightning-lsp-common --scope salesforcedx-vscode-lightning && lerna exec yarn unlink @salesforce/lwc-language-server @salesforce/lightning-lsp-common --scope salesforcedx-vscode-lwc", | |||
| "report:installs": "ts-node scripts/reportInstalls.ts" | |||
| "report:installs": "ts-node scripts/reportInstalls.ts", | |||
| "automation-tests": "npm run compile && node ./packages/salesforcedx-vscode-automation-tests/lib/test-setup-and-runner.js" | |||
There was a problem hiding this comment.
can you create a follow up WI to move each test to the extension it belongs to? let's say the tests that belong to the apex e2e category should go in packages/salesforcedx-vscode-apex/test/e2e-tests and so on
There was a problem hiding this comment.
.github/workflows/runE2ETest.yml
Outdated
| @@ -55,7 +45,7 @@ jobs: | |||
| mv ./extensions/*/* ./extensions/ | |||
| working-directory: salesforcedx-vscode | |||
| env: | |||
| GITHUB_TOKEN: ${{ secrets.IDEE_GH_TOKEN }} | |||
| GH_TOKEN: ${{ secrets.IDEE_GH_TOKEN }} | |||
There was a problem hiding this comment.
my bad, is old remnant will revert this change.
* fix: fallout from changing LSP restart function Notification modal is dead to me, cmd palette quick pick is my new best friend
* feat: delete from project and org right click * chore: pointless path join
| - name: Run headless test | ||
| uses: coactions/setup-xvfb@b6b4fcfb9f5a895edadc3bc76318fae0ac17c8b3 | ||
| with: | ||
| run: | | ||
| npm run automation-tests | ||
| working-directory: ${{ inputs.automationRepo }} | ||
| working-directory: salesforcedx-vscode | ||
| env: |
There was a problem hiding this comment.
@madhur310 I think we need to pass the VSIX_TO_INSTALL value here to get rid of the error you shared in slack
There was a problem hiding this comment.
same for DEV_HUB_ALIAS_NAME
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the e2e tests to salesforcedx-vscode package. Triggered them here - https://github.com/forcedotcom/salesforcedx-vscode/actions/runs/14152916419
What does this PR do?
Moves the e2e tests from a separate package to vscode.
What issues does this PR fix or reference?
@W-18078038@
Functionality Before
tests lived in a different package and were checked out and run via GHW.
Functionality After
tests live in the same package, so no need to checkout and simplifies GHW a little bit.