test: remove clightning TODO-EXTERNAL requiring to disable offers

Author: jonasnick

examples/deploy-container-minimal.sh

@@ -21,12 +21,8 @@ cat > "$tmpDir/configuration.nix" <<EOF
       password = "a";
     };
     # When WAN is disabled, DNS bootstrapping slows down service startup by ~15 s
-    # TODO-EXTERNAL:
-    # When bitcoind is not fully synced, the offers plugin in clightning 24.05
-    # crashes (see https://github.com/ElementsProject/lightning/issues/7378).
     services.clightning.extraConfig = ''
       disable-dns
-      disable-plugin=offers
     '';
   }
 EOF

examples/deploy-container.sh

@@ -83,13 +83,6 @@ read -rd '' src <<EOF || true
         $(realpath "$configuration")
       ];
       nix-bitcoin.generateSecrets = true;
-
-      # TODO-EXTERNAL:
-      # When bitcoind is not fully synced, the offers plugin in clightning 24.05
-      # crashes (see https://github.com/ElementsProject/lightning/issues/7378).
-      services.clightning.extraConfig = ''
-        disable-plugin=offers
-      '';
     };
   };
 }

examples/deploy-qemu-vm.sh

@@ -30,13 +30,6 @@ nix-build --out-link "$tmpDir/vm" - <<'EOF'
       <qemu-vm/vm-config.nix>
     ];
     nix-bitcoin.generateSecrets = true;
-
-    # TODO-EXTERNAL:
-    # When bitcoind is not fully synced, the offers plugin in clightning 24.05
-    # crashes (see https://github.com/ElementsProject/lightning/issues/7378).
-    services.clightning.extraConfig = ''
-      disable-plugin=offers
-    '';
   };
 }).config.system.build.vm
 EOF

examples/krops-vm-configuration.nix

@@ -4,11 +4,4 @@
     <nix-bitcoin/modules/deployment/krops.nix>
     <qemu-vm/vm-config.nix>
   ];
-
-  # TODO-EXTERNAL:
-  # When bitcoind is not fully synced, the offers plugin in clightning 24.05
-  # crashes (see https://github.com/ElementsProject/lightning/issues/7378).
-  services.clightning.extraConfig = ''
-    disable-plugin=offers
-  '';
 }

examples/qemu-vm/minimal-vm.nix

@@ -27,12 +27,8 @@ rec {
       nix-bitcoin.generateSecrets = true;
       services.clightning.enable = true;
       # disable-dns leads to faster startup in offline VMs
-      # TODO-EXTERNAL:
-      # When bitcoind is not fully synced, the offers plugin in clightning 24.05
-      # crashes (see https://github.com/ElementsProject/lightning/issues/7378).
       services.clightning.extraConfig = ''
         disable-dns
-        disable-plugin=offers
       '';
 
       # Avoid lengthy build of the nixos manual

test/clightning-replication.nix

@@ -24,12 +24,8 @@ let
 
       # TODO-EXTERNAL:
       # When WAN is disabled, DNS bootstrapping slows down service startup by ~15 s.
-      # TODO-EXTERNAL:
-      # When bitcoind is not fully synced, the offers plugin in clightning 24.05
-      # crashes (see https://github.com/ElementsProject/lightning/issues/7378).
       extraConfig = ''
         disable-dns
-        disable-plugin=offers
       '';
     };
   };

test/tests.nix

@@ -43,12 +43,8 @@ let
 
       # TODO-EXTERNAL:
       # When WAN is disabled, DNS bootstrapping slows down service startup by ~15 s.
-      # TODO-EXTERNAL:
-      # When bitcoind is not fully synced, the offers plugin in clightning 24.05
-      # crashes (see https://github.com/ElementsProject/lightning/issues/7378).
       services.clightning.extraConfig = ''
         ${optionalString config.test.noConnections "disable-dns"}
-        disable-plugin=offers
       '';
       test.data.clightning-plugins = let
         plugins = config.services.clightning.plugins;