Skip to content

add basic authentication features #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 71 commits into from
Jul 13, 2025
Merged

add basic authentication features #855

merged 71 commits into from
Jul 13, 2025
+8,710 −169

Conversation

Udhay-Adithya
Copy link
Contributor

@Udhay-Adithya Udhay-Adithya commented Jun 7, 2025 •
edited
Loading

PR Description

This PR includes support for these authentication types: Basic, Bearer, JWT Bearer, API Key and Digest Auth

Current Progress/Upcoming changes: discussions/851

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I am using the latest Flutter stable branch (run flutter upgrade and verify)
  • I have run the tests (flutter test) and all tests are passing

Added/updated tests?

  • Yes
  • No

OS on which you have developed and tested the feature?

  • Windows
  • macOS
  • Linux

animator
animator reviewed Jun 14, 2025
View reviewed changes
animator
animator reviewed Jun 14, 2025
View reviewed changes
@animator
Copy link
Member

Change name of URL Parameters to Params
Auth tab should come after Params not at the end.

animator
animator reviewed Jun 14, 2025
View reviewed changes
animator
animator reviewed Jun 14, 2025
View reviewed changes
lib/screens/home_page/editor_pane/details_card/request_pane/request_auth.dart
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropdown is not as per design system.
The UI is not following our design system.

How our text fields look like
Screenshot 2025-06-14 at 8 58 38 PM

How this UI textfield looks
Screenshot 2025-06-14 at 8 58 34 PM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is not maintainable
You have put the entire Ui in a single file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Udhay-Adithya Do not mark any comment as resolved. Just add a comment once the issue is resolved. The reviewer will verify it and mark it as resolved.

animator
animator reviewed Jun 14, 2025
View reviewed changes
animator
animator reviewed Jun 14, 2025
View reviewed changes
animator
animator reviewed Jun 14, 2025
View reviewed changes
@Udhay-Adithya
Copy link
Contributor Author

Udhay-Adithya commented Jun 19, 2025 •
edited
Loading

fvp has been updated from 0.30.0 ~> 0.32.1 due to this error,

Launching lib/main.dart on iPhone 16 Plus in debug mode...
Xcode build done.                                            8.2s
Failed to build iOS app
Error (Xcode): ../../.pub-cache/hosted/pub.dev/fvp-0.30.0/lib/src/controller.dart:31:29: Error: The getter 'textureId' isn't defined for the class 'VideoPlayerController'.

Could not build the application for the simulator.
Error launching application on iPhone 16 Plus.

Exited (1).

The same error occurs with all other platforms. This started to occur after upgrading Flutter from 3.29.x ~> 3.32.4.

@Udhay-Adithya
feat: add authentication support with APIAuthType and APIAuthModel
171a118 
- Introduced APIAuthType enum for various authentication methods.
- Created APIAuthModel with basic authentication fields.
- Updated RequestModel to include authType and authData.
- Implemented EditAuthType widget for selecting and managing authentication.
- Enhanced CollectionStateNotifier to handle authentication updates.

:wq
@Udhay-Adithya
feat: improve authentication model with BearerToken, APIKey, and JWTB…
4177065 
…earer support
@Udhay-Adithya
feat: implement authentication handling in HTTP requests
51fe211
@Udhay-Adithya
feat: implement new authentication models
6a2d1fd
@Udhay-Adithya
feat: refactor authentication handling to use new ApiAuthModel and up…
449e325 
…date related components
@Udhay-Adithya
fix: input text field error
efaebd0
@Udhay-Adithya
fix:prevent text field rebuild on watch
1540d84
@Udhay-Adithya
feat: enhance JWT authentication handling with new fields and JWT gen…
52a1feb 
…eration utility
@Udhay-Adithya
fix: state persistance upon api type switch
a48d059
@Udhay-Adithya
chore: generate lock files
88017a9
@Udhay-Adithya
fix: update authorization label and reorder request pane
0d7f1a9
@Udhay-Adithya
refactor: reorganize import statements
fd92206
@Udhay-Adithya
refactor: rename ApiAuthModel to AuthModel and authData to authModel
d046d50
@Udhay-Adithya
refactor: rename authData to authModel and update related tests
74c0959
@Udhay-Adithya
feat: split authentication related fields into seperate files
bb10ad6
@Udhay-Adithya
feat: change text field design
ff23413
@Udhay-Adithya
feat: replace DropdownButtonFormField with ADPopupMenu for improved U…
0ec2120 
…I consistency
@Udhay-Adithya
feat: update AuthModel serialization to use explicitToJson for nested…
5be9ffd 
… objects
This was linked to issues Jul 13, 2025
Add API Auth: Basic authentication #610
Closed
Add API Auth: JWT Bearer #613
Closed
Add API Auth: Digest Auth #614
Closed
Add API Auth: Bearer token #612
Closed
Add API Auth: API key #611
Closed
@animator
Copy link
Member

LGTM 🚀

@animator animator merged commit 572688c into foss42:main Jul 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@animator animator animator left review comments

Assignees
No one assigned
Labels
gsoc25
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add API Auth: Digest Auth Add API Auth: JWT Bearer Add API Auth: Bearer token Add API Auth: API key Add API Auth: Basic authentication
2 participants
@Udhay-Adithya @animator