Skip to content

Commit a2cf168

Browse files
committed
pkgs/phps: Fix type error
configureFlags should take array but lib.optionalString will return a string when the condition is false. It only ever worked because we always run the code on PHP < 7.4 and lib.optionalString returns the argument as is when the condition is false.
1 parent 29c9d97 commit a2cf168

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

pkgs/phps.nix

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ let
4343

4444
configureFlags =
4545
attrs.configureFlags
46-
++ prev.lib.optionalString (prev.lib.versionOlder args.version "7.4") [
46+
++ prev.lib.optionals (prev.lib.versionOlder args.version "7.4") [
4747
# phar extension’s build system expects hash or it will degrade.
4848
"--enable-hash"
4949
];

0 commit comments

Comments
 (0)