Skip to content

Commit 68521ee

Browse files
thechaos16facebook-github-bot
authored andcommitted
update layout-bin-packer from 1.2.2 to 1.4.0 (#405)
Summary: <!--- Provide a general summary of your changes in the Title above --> <!--- Describe your changes in detail --> Update version of layout-bin-packer from 1.2.2 to 1.4.0 in launching visdom server <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> closes #404 I have been suffered same issue, and solved it in the same way <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, experiments you ran to see how --> <!--- your change affects existing areas of the code and their behaviors, etc. --> <!--- One method of testing is to run the `demo.py` script from the examples --> <!--- both on your branch and a clean branch and ensure that none of the functionality --> <!--- appears different. Be sure to install from source when testing. --> 1. downloading test via wget - 1.2.2 ![2018-06-28 1 56 06](https://user-images.githubusercontent.com/16028452/42014003-04af70d2-7adb-11e8-8815-f715d27bae40.png) - 1.4.0 ![2018-06-28 1 56 18](https://user-images.githubusercontent.com/16028452/42014013-0d6d8434-7adb-11e8-8cc2-d1cd813a3f8b.png) 2. launching visdom server (`python -m visdom.server`) - 1.2.2 ![2018-06-28 1 46 50](https://user-images.githubusercontent.com/16028452/42014031-1cce28e8-7adb-11e8-8969-e6b1ae937a40.png) - 1.4.0 ![2018-06-28 1 47 21](https://user-images.githubusercontent.com/16028452/42014036-203d0a94-7adb-11e8-8d0a-2abc30d7bccc.png) 3. on visdom web - skip 1.2.2 because it does not show anything - 1.4.0 ![2018-06-28 1 42 44](https://user-images.githubusercontent.com/16028452/42014058-38e26eea-7adb-11e8-85d4-c0c7f3f13421.png) <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] For JavaScript changes, I have re-generated the minified JavaScript code. Closes #405 Differential Revision: D8677772 Pulled By: JackUrb fbshipit-source-id: 7878930e745c2d955ef1573a4303d6b9a892555a
1 parent 6f25e5f commit 68521ee

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

download.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ wget https://unpkg.com/bootstrap@3.3.7/dist/css/bootstrap.min.css -O py/static/c
1818

1919
mkdir -p py/static/fonts
2020
wget https://unpkg.com/classnames@2.2.5 -O py/static/fonts/classnames
21-
wget https://unpkg.com/layout-bin-packer@1.2.2 -O py/static/fonts/layout_bin_packer
21+
wget https://unpkg.com/layout-bin-packer@1.4.0 -O py/static/fonts/layout_bin_packer
2222
wget https://unpkg.com/bootstrap@3.3.7/dist/fonts/glyphicons-halflings-regular.eot -O py/static/fonts/glyphicons-halflings-regular.eot
2323
wget https://unpkg.com/bootstrap@3.3.7/dist/fonts/glyphicons-halflings-regular.woff2 -O py/static/fonts/glyphicons-halflings-regular.woff2
2424
wget https://unpkg.com/bootstrap@3.3.7/dist/fonts/glyphicons-halflings-regular.woff -O py/static/fonts/glyphicons-halflings-regular.woff

py/visdom/server.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1006,7 +1006,7 @@ def download_scripts(proxies=None, install_dir=None):
10061006

10071007
# - fonts
10081008
'%sclassnames@2.2.5' % b: 'classnames',
1009-
'%slayout-bin-packer@1.2.2' % b: 'layout_bin_packer',
1009+
'%slayout-bin-packer@1.4.0' % b: 'layout_bin_packer',
10101010
'%sfonts/glyphicons-halflings-regular.eot' % bb:
10111011
'glyphicons-halflings-regular.eot',
10121012
'%sfonts/glyphicons-halflings-regular.woff2' % bb:

0 commit comments

Comments
 (0)