Add Cache Miss/Hit Test #97
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-jw-brooks
force-pushed
the
rebased_cache_tests
branch
from
1711ea7 to
1be911b
Compare
Signed-off-by: Avery Blanchard <avery.blanchard@ibm.com> Signed-off-by: Alex-Brooks <Alex.Brooks@ibm.com>
Signed-off-by: Alex-Brooks <Alex.Brooks@ibm.com>
commit ed571f728a351f8dd92737be5554c3dc46f71a30
Author: Alex-Brooks <Alex.Brooks@ibm.com>
Date: Tue Jul 29 09:20:06 2025 -0600
Remove cache tests
commit 2848f7b2785b91c60c536b8993c3193c40c381ea
Author: Alex-Brooks <Alex.Brooks@ibm.com>
Date: Mon Jul 28 08:07:01 2025 -0600
Add leading underscores, revert model name
commit c30b7b70a0f6e464d3212fd9bed4f9ea33f9de93
Author: Alex-Brooks <Alex.Brooks@ibm.com>
Date: Mon Jul 28 07:15:08 2025 -0600
Explictly clear cache paths
commit 42aaf666d7f8ffb2fb611df7ad2d06b48e480dd7
Author: Alex-Brooks <Alex.Brooks@ibm.com>
Date: Mon Jul 28 07:14:23 2025 -0600
Set the cache dir in conftest
commit b978e7225f02bf1d9a5f7b919ca6cbe2ee8d641a
Author: Alex-Brooks <Alex.Brooks@ibm.com>
Date: Mon Jul 28 06:15:10 2025 -0600
run formatting
commit 8d64df08333991927c45f9a982ddaf95f39c94cf
Author: Alex-Brooks <Alex.Brooks@ibm.com>
Date: Fri Jul 25 11:18:13 2025 -0600
refactor cache miss into fixture
commit 0b524b8c818495cb646add2adfc27a2884ac8de5
Author: Alex-Brooks <Alex.Brooks@ibm.com>
Date: Fri Jul 25 07:11:09 2025 -0600
Consolidate cache test with common
commit d8a36d405a101e101ab9ede3b8d12fa3026cd01f
Author: Alex-Brooks <Alex.Brooks@ibm.com>
Date: Fri Jul 25 06:41:13 2025 -0600
Run cache test first
commit 2efb797fb21587e9136b314c44ec56c658636826
Author: Alex-Brooks <Alex.Brooks@ibm.com>
Date: Fri Jul 25 05:48:25 2025 -0600
Finish splitting out common shape test helpers
commit 4ae73dea18848005f86d1c9bcdf29f153711330f
Author: Alex-Brooks <Alex.Brooks@ibm.com>
Date: Fri Jul 25 05:28:31 2025 -0600
refactor most of common shape test
commit 083afdc3a468649ec4b0bbadc921d40b47e37498
Author: Alex-Brooks <Alex.Brooks@ibm.com>
Date: Thu Jul 24 14:08:20 2025 -0600
Move torch sendnn cache dir to common
commit e9b576381a738c59f91d5fc904ceaa2a0e410864
Author: Alex-Brooks <Alex.Brooks@ibm.com>
Date: Thu Jul 24 14:02:06 2025 -0600
Use caps for constants, common post proc
Signed-off-by: Alex-Brooks <Alex.Brooks@ibm.com>
Signed-off-by: Alex-Brooks <Alex.Brooks@ibm.com>
alex-jw-brooks
force-pushed
the
rebased_cache_tests
branch
from
1be911b to
ad3073c
Compare
This was referenced Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #20 and #93 to add a cache for testing using the refactored version of the test to allow some code reuse. #93 should probably be merged first (splitting this out for readability).
Summary of changes (wrt the original cache test PR)
- Makes sure gptq kwargs are passed through to the AIU model
- Makes sure
options={"sendnn.dynamic": COMPILE_DYNAMIC_SENDNN}is passed consistently- Clears the torch sendnn
.cache- the current PR can break if the cache test runs second since the cache paths aren't actually reset in torch sendnn. We reset the compiler settings and clear the directory, but don't clear the spyre cache object in the current PR, which causes alignment issues if the cache test doesn't run first- The current PR runs the check as two tests (cache miss -> cache hit); moves the cache miss test to run as a fixture to set things up so that we can just run cache hit as the test
Note that there is still some weirdness around how micro models are handled, mostly due to the way we configure common models paths / micro model usage and also check thresholds based on whether micro models exist.