Skip to content

Commit 8e7c429

Browse files
committed
Address review comments
1 parent 792133e commit 8e7c429

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

src/clients.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ pub async fn create_http_clients(
116116
panic!("error reading cert from {cert_path:?}: {error}")
117117
});
118118
let identity = reqwest::Identity::from_pem(&cert_pem)
119-
.unwrap_or_else(|error| panic!("error creating identity: {error}"));
119+
.unwrap_or_else(|error| panic!("error parsing cert: {error}"));
120120
builder = builder.use_rustls_tls().identity(identity);
121121
}
122122
let client = builder

src/orchestrator.rs

+3-1
Original file line numberDiff line numberDiff line change
@@ -142,13 +142,15 @@ impl Orchestrator {
142142
}
143143
});
144144
match task_handle.await {
145+
// Task completed successfully
145146
Ok(Ok(result)) => Ok(result),
147+
// Task failed, return error propagated from child task that failed
146148
Ok(Err(error)) => {
147149
error!(request_id = ?task.request_id, %error, "unary task failed");
148150
Err(error)
149151
}
152+
// Task cancelled or panicked
150153
Err(error) => {
151-
// Task failed due to cancellation or panic
152154
let error = error.into();
153155
error!(request_id = ?task.request_id, %error, "unary task failed");
154156
Err(error)

0 commit comments

Comments
 (0)