👷🐛 Use docker for test run #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evaline Ju <69598118+evaline-ju@users.noreply.github.com>
Signed-off-by: Evaline Ju <69598118+evaline-ju@users.noreply.github.com>
Signed-off-by: Evaline Ju <69598118+evaline-ju@users.noreply.github.com>
Signed-off-by: Evaline Ju <69598118+evaline-ju@users.noreply.github.com>
evaline-ju
force-pushed
the
fix-ci
branch
2 times, most recently
from
1366343 to
21e9115
Compare
Signed-off-by: Evaline Ju <69598118+evaline-ju@users.noreply.github.com>
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formatting, linting and tests all require protoc and compilation of files. Since the goal of this repo is to output an image, and we are already installing protoc in the Docker image, we can essentially reuse parts of the image build. A failure at any stage will lead to "build" failure.
Usage of GHA caching taken from https://github.com/IBM/text-generation-inference. Docker build actions are used in order to standardize docker usage and allow for caching. The file was renamed since the focus is on "building" to allow for testing and formatting, etc., but a future build workflow could
buildfrom the release tag and potentially push an image to a registryFor: #34