🥅🏷️ Use more defined struct for threshold #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Evaline Ju <69598118+evaline-ju@users.noreply.github.com>
declark1
reviewed
Jun 6, 2024
gkumbhat
reviewed
Jun 7, 2024
Sure, it seemed initially like unnecessary precision for thresholds but we are maintaining |
Signed-off-by: Evaline Ju <69598118+evaline-ju@users.noreply.github.com>
Signed-off-by: Evaline Ju <69598118+evaline-ju@users.noreply.github.com>
declark1
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detector parameters provided for each detector will not be passed to each detector client currently. The one expected parameter currently is
threshold, used by the orchestrator to potentially filter each detector's results. Including this named parameter allows for a more defined type and validation (as opposed to theserde_jsonvalue that would have allowed comparison of scores to strings)Closes: #64