Skip to content

Fix additional callbacks #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 25, 2024
Merged

Fix additional callbacks #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
110c26e
fix: concatenate the trainer_callbacks and additional_callbacks in sf…
VassilisVassiliadis Jun 14, 2024
e016840
test: add a unit test for additional_callbacks param of train()
VassilisVassiliadis Jun 14, 2024
8905904
chore: fix formating of test_run_with_additional_callbacks
VassilisVassiliadis Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions tests/test_sft_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@

# Third Party
from datasets.exceptions import DatasetGenerationError
from transformers.trainer_callback import TrainerCallback
import pytest
import torch
import transformers
Expand Down Expand Up @@ -616,3 +617,20 @@ def test_bad_torch_dtype():

with pytest.raises(ValueError):
sft_trainer.train(model_args, DATA_ARGS, train_args, PEFT_PT_ARGS)


def test_run_with_additional_callbacks():
"""Ensure that train() can work with additional_callbacks"""

with tempfile.TemporaryDirectory() as tempdir:
train_args = copy.deepcopy(TRAIN_ARGS)
train_args.output_dir = tempdir
model_args = copy.deepcopy(MODEL_ARGS)

sft_trainer.train(
model_args,
DATA_ARGS,
train_args,
PEFT_PT_ARGS,
additional_callbacks=[TrainerCallback()],
)
2 changes: 1 addition & 1 deletion tuning/sft_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ def train(

# Add any extra callback if passed by users
if additional_callbacks is not None:
trainer_callbacks.append(additional_callbacks)
trainer_callbacks.extend(additional_callbacks)

framework = AccelerationFrameworkConfig.from_dataclasses(
quantized_lora_config, fusedops_kernels_config
Expand Down
Loading