Skip to content

ENS naming for contracts #10605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

abhijeetbhagat
Copy link

Motivation

this issue #10604

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@zerosnacks
Copy link
Member

Hi @abhijeetbhagat thanks for your PR,

In my opinion, as a principle Foundry does not directly integrate third party services to remain a neutral actor. I am against recording metrics from users and collecting possibly identifying data such as IP addresses.

@conor10
Copy link

conor10 commented Jun 10, 2025

Thanks for your comment @zerosnacks, we have two motivations for connecting to the service:

  1. To provide the necessary ENS contract configuration for the various networks we support. Otherwise this will need to be provided by the user, or stored in Foundry. This would impact UX for users, as there's a number of contract addresses that are required, and they may change. Hence users may misconfigure the contracts, also Foundry could end up with out of date configuration as contract addresses can change.
  2. To capture which contract ENS names are being registered by the service. This is so we can measure adoption. We are not trying to capture any information that doesn't end up onchain. If we can't measure adoption of the service, its much harder for us as a team to demonstrate traction and impact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants