Skip to content

fix: Respect --override-* flags on cast call with --trace flag #10721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Yen
Copy link

@Yen Yen commented Jun 5, 2025

Fixes #10720

Copy link
Collaborator

@grandizzy grandizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! I think it makes sense, we'd need some tests for it too.
what do others think re adding such?

@Yen
Copy link
Author

Yen commented Jun 6, 2025

I have looked at the existing tests for --override and they use the stderr_eq check to ensure the output is expected. If I add additional tests in the case of --trace this output is more complex and I assume it will change more often. Is it ok for the tests to fail when the format of the trace changes in the future, would the expectation be that the tests are updated to reflect this?

@Yen
Copy link
Author

Yen commented Jun 6, 2025

Ah, actually I did not see the SNAPSHOTS=overwrite functionality which I assume is meant to assist in this case. I will add equivalent tests to the existing --override tests with the --trace flag enabled.

@Yen Yen requested a review from grandizzy June 6, 2025 14:19
@Yen Yen force-pushed the fix/cast-call-trace-overrides branch from 2d8f9d7 to 007b3e5 Compare June 13, 2025 13:01
@Yen Yen force-pushed the fix/cast-call-trace-overrides branch from 007b3e5 to 66a282b Compare June 13, 2025 13:03
@Yen
Copy link
Author

Yen commented Jun 13, 2025

I have added tests and rebased onto the latest master. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

bug(cast call): --override-* flags not respected with --trace
2 participants