Support aliases in calldata#4383
Open
DelevoXDG wants to merge 7 commits into
Open
Conversation
This was referenced May 25, 2026
969d2b7 to
b7493cf
Compare
ed6a019 to
3899792
Compare
77e59b4 to
7abce6b
Compare
3899792 to
029558e
Compare
7abce6b to
591f51c
Compare
029558e to
397b0ff
Compare
591f51c to
e7c0409
Compare
397b0ff to
bff4b4b
Compare
maciektr
pushed a commit
to maciektr/starknet-foundry
that referenced
this pull request
May 29, 2026
<!-- Reference any GitHub issues resolved by this PR --> Towards foundry-rs#2240 ## Stack - foundry-rs#4365 - foundry-rs#4366 - foundry-rs#4376 - foundry-rs#4382 - foundry-rs#4383 ## Introduced changes - Initial alias logic setup; `[sncast.<profile>.aliases]` in `snfoundry.toml` - Support alias in `--contract-address` in `call`, `invoke` - **tests:** `call` and `invoke` (alias resolves, unknown alias fails) ## Checklist <!-- Make sure all of these are complete --> - [x] Linked relevant issue - [x] Updated relevant documentation - [x] Added relevant tests - [x] Performed self-review of the code - [x] Added changes to `CHANGELOG.md` --------- Co-authored-by: Franciszek Job <54181625+franciszekjob@users.noreply.github.com>
maciektr
pushed a commit
to maciektr/starknet-foundry
that referenced
this pull request
May 29, 2026
…#4366) <!-- Reference any GitHub issues resolved by this PR --> Towards foundry-rs#2240 ## Stack - foundry-rs#4365 - foundry-rs#4366 - foundry-rs#4376 - foundry-rs#4382 - foundry-rs#4383 ## Introduced changes <!-- A brief description of the changes --> - add `alias list` - show aliases from effective config - update `show-config` - display number of configured aliases ## Checklist <!-- Make sure all of these are complete --> - [x] Linked relevant issue - [x] Updated relevant documentation - [x] Added relevant tests - [ ] Performed self-review of the code - [x] Added changes to `CHANGELOG.md` --------- Co-authored-by: Franciszek Job <54181625+franciszekjob@users.noreply.github.com>
franciszekjob
approved these changes
May 29, 2026
9d9ad68 to
85151b6
Compare
- `--calldata` - `--constructor-calldata`
e9de00c to
1db7a32
Compare
MKowalski8
approved these changes
Jun 1, 2026
Contributor
MKowalski8
left a comment
There was a problem hiding this comment.
Left some comments, apart from that LGTM.
Also I assume existing CHANGLOG entry is enough?
I mean it's okay for me, just checking.
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn test_invoke_with_calldata_alias() { |
Contributor
There was a problem hiding this comment.
nit: For call there is an Error test. If you find it useful we can add similar test for invoke and deploy as well.
Co-authored-by: Maksymilian Kowalski <126796018+MKowalski8@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2240
Stack
call,invoke) #4365alias list; Updateshow-configto display aliases #4366Introduced changes
@aliasin--calldataand--constructor-calldata(call,invoke,deploy,multicall deploy/invoke)call,deploy,invoke,utils contract-addressChecklist
CHANGELOG.md