Improve e2e CI workflow #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtbandes
approved these changes
Nov 25, 2024
Comment on lines
-88
to
-90
| # Note: this does not use the `npm run package` command since that would use the | ||
| # version of foxglove-extension scripts specified in the package.json which is not the local | ||
| # version of the scripts. |
There was a problem hiding this comment.
is this no longer true? Because of the new npm install step?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
None
Docs
None
Description
Improve the e2e tests by using a packaged build of the
create-foxglove-extensionpackage. This packaged build tarball is used with thenpxcommand to test thenpx initfunctionality. This same tarball is installed into thesampleextension to confirm thepackagescript specified in the sample package.json works.