Modernize examples #163
Modernize examples #163
Conversation
|
|
||
| const foxglove = require("@foxglove/eslint-plugin"); | ||
| const globals = require("globals"); | ||
| const tseslint = require("typescript-eslint"); |
There was a problem hiding this comment.
typescript-eslint is missing from package.json (I think this applies to all the examples)
There was a problem hiding this comment.
🤔 I did run npm run lint in each example (installing packages only in that example) and it ran. Maybe something else had it as a transient.
There was a problem hiding this comment.
https://www.npmjs.com/package/@foxglove/eslint-plugin?activeTab=dependencies It is already a dependency of @foxglove/eslint-plugin
There was a problem hiding this comment.
Sure but don’t we always ensure that we declare dependencies on things we explicitly import? That is what our dependency lint step does in the app repo.
There was a problem hiding this comment.
🤔 Yea I could see that. I guess my dream is the users worry about fewer dependencies.
| const tseslint = require("typescript-eslint"); | ||
|
|
||
| module.exports = tseslint.config({ | ||
| files: ["src/**/*.ts", "src/**/*.tsx"], |
There was a problem hiding this comment.
I think putting this files restriction at the top level may mean that this eslint.config.js file itself is not linted (and any other .js files). Would be interesting to confirm that. Maybe not the end of the world but it feels nice to lint all JS & TS files.
Changelog
None
Docs
None
Description
Update examples to use React 18, Eslint v9, and latest versions of @foxglove packages
I deleted the simple-3d-extension. I did not feel that was adding good value to continue having it around. There is nothing special it did with config, setup, etc compared to a typical example panel.
Will also resolve #162