-
Notifications
You must be signed in to change notification settings - Fork 26
rust data loader example #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust data loader example #171
Conversation
prost = "0.13" | ||
serde = { version = "1.0", features = [ "derive" ] } | ||
foxglove_data_loader = { path = "../../../../sdk/rust/foxglove_data_loader" } | ||
foxglove_data_loader = { git = "https://github.com/foxglove/foxglove-sdk.git" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we set this to a specific commit so that if we iterate on the api the example remains valid until we explicitly update it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that could work so long as the WIT interface upstream in app doesn't change very often
Upstream in let init = self.init.borrow();
let acc_ch_id = init.get_channel("/accelerometer").unwrap().id;
let temp_ch_id = init.get_channel("/temperature").unwrap().id; |
Now the trait interface methods are |
…te-foxglove-extension-support-for-data-loaders
Changelog
Adds rust data loader example.
Docs
None
Description
This PR adds a rust data loader example with the example file from the
foxglove_data_loader
in foxglove-sdk/#460 plus the typescript build to generate the extension.The example in the sdk repo is rust-only to keep that repo simpler and so that users can understand only that rust code in isolation, but the example here in create-foxglove-extension is more complete and something we can point people to for everything they will need to make an extension of their own.
Replaces #169.
Fixes: FG-11789
Depends on foxglove/foxglove-sdk#460